July Report

This will be my last report, until the beginning of September. I have, for many years, been a volunteer at the Edmonton Folk Music Festival. For the next month, I will be busy setting it up (and then taking it down, and so will not have time to devote to twisted.

This month, 23 tickets got some attention that they would not have received without the sponsored development. The result was 5 closed tickets and 11 other tickets unblocked for other developers to resume work on.

This month, I made a number of improvements to the buildobt:

• Switched most of the buildslaves to use git to checkout the source.
• All the git-using builders merge to trunk, before running tests, so the tests results reflect the code as it would be merged. In particular, all the lint steps should now accurately report only the regressions relative to current trunk of the merged result.
• I added a bunch of new builders on VMs provided by Rackspace (thanks to Jesse Noller) and the Fedora Project (thanks to Seth Vidal). These cover all recent versions of Debian, Fedora, Ubuntu and RHEL. As part of this, I automated the deployment of buildslaves, (currently only Debian and Fedora derivatives are supported).

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #5574: Add support for SOCK_DGRAM to IReactorSocket
• #6221: Replace Deprecated Test Case Assertion Methods in twisted.internet
• #6393: Utility function to pretty-format list of things
• #6475: FileAuthority._lookup incorrectly returns AuthoritativeDomainError for non-subdomain names which happen to share the same suffix as the zone (eg the-example.com and example.com)
• #6572: twisted.mail.smtp.sendmail should return a cancellable Deferred

Other tickets I have reviewed:

• #2699: UDP DatagramProtocol reconnecting
• #3926: twisted.positioning – a better positioning framework
• #4173: WebSocket server support
• #4735: Implement something like ReconnectingClientFactory for endpoints
• #5001: replace call to functions from the string module in twisted.scripts.tap2deb
• #5004: replace call to functions from the string module in web
• #5685: SMTP Client Tutorial should be self-contained
• #6556: LineReceiver rejects lines of length MAX_LENGTH sometimes
• #6557: LineOnlyReceiver doesn't disconnect the transport when it detects an overlarge line
• #6558: LineOnlyReceiver doesn't pass the entire contents of its buffer to lineLengthExceeded()
• #6580: twisted.names.server.DNSServerFactory should query child zones before parent zones

Tickets I have worked on:

• #5513: Detailed documentation on Proxy by adding docstrings to many of the methods.
• #6537: Update coding-standard to reflect that documentation should be sentence per line.
• #6620: Document conventions for writting test assertions.
• #6626: Remove all uses of deferredGenerator.

June End-month report

I spent the majority of my time in the last half of the month, clearing the review queue, from 45 tickets when I started to a low of 19 tickets. All told, 34 tickets got some attention that they would not have received without the sponsored development. The result was 9 closed tickets and 22 other tickets unblocked for other developers to resume work on.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #5329: Replace deprecated string functions with str methods in t.w.p.irc
• #5894: ckeygen –changepass truncates private keys to zero bytes
• #5992: twistd dns without any options crashes when it is queried
• #5780: words: Unbound variable nickname in IRCUser for invalid user name
• #6217: iocpreactor events do not occur at the time they should
• #6220: Replace Deprecated Assertion Methods in twisted.conch
• #6328: twisted.names.client lookup functions duplicate or reference the documentation of `IResolver`
• #6499: Teach chain certificates to SSL server endpoints string syntax
• #6544: Replace usage of twisted.python.text in twisted.words

Other tickets I have reviewed:

• #2835: _pollingfile calls pauseProducing on registered Pull producers
• #2839: _pollingfile fails to call stopProducing when connection is lost
• #4353: Automate uploading pre-release tarballs
• #5001: replace call to functions from the string module in twisted.scripts.tap2deb
• #5004: replace call to functions from the string module in web
• #5387: Get rid of references and code specific to Python 2.4
• #5562: iocp reactor fails to support PB & AMP
• #5574: Add support for SOCK_DGRAM to IReactorSocket
• #5685: SMTP Client Tutorial should be self-contained
• #5795: Failure's startDebugMode should allow using a debugger other than pdb
• #6164: Returning an already-chained deferred breaks the callback chain
• #6357: LineReceiver uses O(n**2) complexity
• #6475: FileAuthority._lookup incorrectly returns AuthoritativeDomainError for non-subdomain names which happen to share the same suffix as the zone (eg the-example.com and example.com)
• #6491: test_pollingfile: producer data wrongly dropped when loseConnection() requested
• #6492: test_pollingfile: bufferEmpty sets producerPaused attribute on the producer instead of on itself
• #6493: test_pollingfile: writeSequence() doesn't pause the producer when outgoing buffer is full
• #6523: Constants HOWTO doesn’t document that constants are ordered.
• #6542: Use of map where the result is unused.
• #6543: Replace usage of twisted.python.text in twisted.conch
• #6545: Replace usage of twisted.python.text in twisted.mail
• #6546: Replace usage of twisted.python.text in twisted.lore
• #6547: Class mail.pb.MaildirBroker apparently broken and obsolete

Tickets I have worked on:

• #6301: There should be some clear documentation on how to document tests.
• #6595: twisted should provide a paste entry point, so that it can be used as a wsgi container by `paster serve`.
• #6596: twisted.application.reactors.installReactor should return the installed reactor.
• #6587: Remove out-of-place refernce to lore and howtos from coding-standard doc.

June Mid-month report

During the first half of the month, 24 tickets got some attention that they would not have received without the sponsored development. The result was 2 closed tickets and 22 other tickets unblocked for other developers to resume work on.

Also, as mentioned before, I've released a collection of tools for helping with twisted development on github and pypi.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #1518: trial option to exit on failure
• #5435: twisted.web.client.RedirectAgent doesn't inform caller of final URI

Other tickets I have reviewed:

• #1601: t.py.text.greedyWrap makes t.py.usage.Options.longdesc ugly
• #2835: _pollingfile calls pauseProducing on registered Pull producers
• #2839: _pollingfile fails to call stopProducing when connection is lost
• #3926: twisted.positioning – a better positioning framework
• #4929: Add LIST to IRCClient
• #5365: _pollingfile makes wrong assumption about WriteFile
• #5574: Add support for SOCK_DGRAM to IReactorSocket
• #5668: Support the OPT pseudo-record
• #5894: ckeygen –changepass truncates private keys to zero bytes
• #6064: Write tests for `twisted.internet.protocol.FileWrapper`
• #6116: twisted.web.http.stringToDatetime has incomplete test coverage
• #6135: twisted.web.http.HTTPFactory is incompletely tested
• #6137: Add unit tests for twisted.python.dist.getAllScripts
• #6217: iocpreactor events do not occur at the time they should
• #6393: Utility function to pretty-format list of things
• #6401: twisted.web.test.requesthelper.DummyChannel.TCP does not have the unregisterProducer method.
• #6475: twistd dns returns NXDomain for valid records when multiple zone names share a common suffix or parent domain
• #6484: Add unit tests for twisted.python.dist.get_setup_args
• #6491: test_pollingfile: producer data wrongly dropped when loseConnection() requested
• #6492: test_pollingfile: bufferEmpty sets producerPaused attribute on the producer instead of on itself
• #6493: test_pollingfile: writeSequence() doesn't pause the producer when outgoing buffer is full
• #6499: Teach chain certificates to SSL server endpoints string syntax

May end-of-month report

The migration to the new machine has been successfully completed, and reports are, that trac is much faster now. Special thanks to Jonathan Stoppani, whose help was invaluable in preparing for the migration.

Since the migration, I've returned to doing ticket review, 11 tickets got some attention that they would not have received without the sponsored development. The result was 2 closed tickets and 9 other tickets unblocked for other developers to resume work on.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #6443: setuid should be called in the child after forking the process in spawnProcess
• #6525: Constant docs have a mistake in an example

Other tickets I have reviewed:

• #3926: twisted.positioning – a better positioning framework
• #5387: Get rid of references and code specific to Python 2.4
• #5434: Web browser-like redirection Agent for twisted.web.client
• #5787: trial –order for selecting an order for running test cases
• #5795: Failure's startDebugMode should allow using a debugger other than pdb
• #5962: Clock.callLater(0, f) can lead to infinite loop
• #6042: twisted.protocols.test.test_basic doesn't following coding standard
• #6071: t.i.task.react's docstring doesn't mention the reactor argument
• #6166: Deprecate pickling support (__getstate__ and __setstate__) in twisted.internet._sslverfiy

Migration Report

I have completed the migration scripts for deploying the services currently running on cube. They have been run against our new machine, dornkirk which is currently running with a snapshot of data.

It can currently be accessed by putting

66.35.39.66     twistedmatrix.com speed.twistedmatrix.com

in /etc/hosts. Please tests it, and verify that things appear to be working, but be aware that any changes will be lost, when the transition occurs.

At some point Monday or Tuesday, there will be some downtime for mail and the mailing lists, as mail-service is migrated to the new machine. For those that have accounts on cube, your data will be copied to the new machine at this point.

On Wednesday, at about 10 MDT (16 UTC), there will be downtime of all twisted services, as live data is transfered over. This may last up-to a couple of hours.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

April end-month report

During the second half of the month, I have concentrated on the continuing development tools to automate the deployment of twisted infrastructure.

I've also spent some time developing some command-line tools for interacting with trac. It currently support view tickets, listing review tickets, and grabbing attachments (including applying them in git with an appropriate commit message). I plan to add support for doing reviews, as well.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

April mid-month Fellowship report

During the first half of the month, 43 tickets got some attention that they would not have received without the sponsored development. The result was 17 closed tickets and 24 other tickets unblocked for other developers to resume work on.

I set up an official git mirror that contains all the branches, including release branches and tags on github and documented my workflow on the wiki.

I've documened how our current infrastructure (cube), and with the help of Jonathan Stoppani, I've been working on scripts to automate the deployment of its successor (dornkirk).

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #3844 (Parse mIRC format codes)
• #4696 (client endpoint: process)
• #5386 (Get rid of references and code specific to Python 2.3)
• #5411 (ftp_NLST and ftp_LIST should only send data as "str")
• #5952 (Improve docstring for test_notTrapped in twisted.test.test_failure)
• #5955 (Move inlineCallbacks test from twisted.test.test_failure to somewhere better (test_defer?))
• #5989 (Standardize twisted names examples to use task.react)
• #6120 (twisted.web.http.Request.__repr__ is untested)
• #6240 (Merge `twisted/internet/_utilspy3.py` into `twisted/internet/utils.py`)
• #6284 (FTP.ftp_STOR() should handle IsADirectoryError error)
• #6350: Add a few unittest2 assertions to TestCase
• #6391 (Improve the format of http.Request.__repr__ to include eg class and object identity)
• #6392: Typo in test_irc
• #6400 (trial.test.test_directoryNotPackage is incorrect)
• #6405 (os.geteuid and os.getegid are called unnecessarily in SSHPublicKeyDatabase.checkKey)
• #6430 (test_loader.FileTest.test_filenameNotPython should create its test data)
• #6439 (Spelling mistakes in pb-intro.xhtml)

Other tickets I have reviewed:

• #2061: _sslverify.py: Wrong use of param caCerts in OpenSSLCertificateOptions
• #3701: Add a checker for ISSHPrivateKey which parameterizes the location of the keys
• #4891: twisted.web.http does not throttle pipelined requests
• #5228: twisted.test.test_paths.FilePathTestCase.test_getPermissions_Windows creates undeleteable file
• #5270: Add API to endpoints for connecting a protocol instance
• #5329: Replace deprecated string functions with str methods in t.w.p.irc
• #5435: twisted.web.client.RedirectAgent doesn't inform caller of final URI
• #5531: Add anonymous support to Conch SSHFactory
• #5532: AMP Command specification format
• #5787: trial –order for selecting an order for running test cases
• #5795: Failure's startDebugMode should allow using a debugger other than pdb
• #585: Include sendfile(2) support into defaultreactor
• #5951: Documentation for the best way to get a reference to a reactor reads as contradictory
• #6115: twisted.web.http.parseContentRange has no unit tests
• #6119: twisted.web.http.Request.parseCookies has incomplete test coverage
• #6166: Deprecate pickling support (__getstate__ and __setstate__) in twisted.internet._sslverfiy
• #6341: Replace usage of twisted.python.text and deprecate it
• #6342: Deprecate twisted.python.hashlib
• #6390: Using trial -j can result in wrong paths in sys.path
• #6393: Utility function to pretty-format list of things
• #6395: Delete twisted.words.protocols.msn
• #6402: twisted.words setup metadata is not up to date anymore
• #6426: test_mail.py failure
• #6437: twisted.trial.unittest.TestCase.flushWarnings may fail if run without .py files (with only .pyc or .pyo files)

Other tickets I have worked on:

• #6251 (Add a helper function for getting the body of an HTTP request.)
• #6348 (trial doesn't show `DeprecationWarnings` by default on 2.7)

Report the Third

During the past three weeks, 23 tickets got some attention that they would not have received without the sponsored development. The result was 9 closed tickets and 8 other tickets unblocked for other developers to resume work on.

I also spent some time working on getting newly donated slaves setup, as well as documenting the setup of the main twistedmatrix.com server, in preparation for automating the redeployment of services to new hardware.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #1333: Survey existing FTP servers and clients to figure out how LIST works
• #3908: Code using twisted.names.client.Resolver is hard to unit test
• #6240: Merge `twisted/internet/_utilspy3.py` into `twisted/internet/utils.py`
• #6337: OpenSSLCertificateOptions doesn’t disallow SSLv2
• #6354: Main NEWS file is not generated properly anymore
• #6377: print traceback in successResultOf error reporting
• #6380: Add optional expected exception types to failureResultOf
• #6392: Typo in test_irc

Other tickets I have reviewed:

• #5126: Add http cache support to Agent
• #5270: Add API to endpoints for connecting a protocol instance
• #5386: Get rid of references and code specific to Python 2.3
• #5411: ftp_NLST and ftp_LIST should only send data as "str"
• #5955: Move inlineCallbacks test from twisted.test.test_failure to somewhere better (test_defer?)
• #6286: SSL server endpoints string syntax results in creation of DefaultOpenSSLContextFactory
• #6341: Replace usage of twisted.python.text and deprecate it
• #6350: Add a few unittest2 assertions to TestCase

Tickets I have closed:

• #6316: Minor cleanup of pam tests in `twisted.test.test_newcred`.

Other tickets I have worked on:

• #1009: Document inlineCallbacks
• #6251: Add a helper function for getting the body of an HTTP request.
• #6284: FTP.ftp_STOR() should handle IsADirectoryError error
• #6286: SSL server endpoints string syntax results in creation of DefaultOpenSSLContextFactory
• #6363: Make twisted.trial.unittest._iterateTests public.

Second Fellowship Report

I've completed my second two weeks of development. I again spent a large amount of my time reviewing tickets. In addition, I did some development work, as well as buildbot improvements.

All told, 42 tickets got some attention that they would not have received without the sponsored development. The result was 23 closed tickets and 14 other tickets unblocked for other developers to resume work on.

Buildbot improvements

• Added a pyflakes builder.
• Improved lint-like builders to only show new warnings/errors introduced in the branch, rather than relative to the tip of trunk
• Added a form to the build results page to allow switching branches and forcing builds.
• Added an easy way to look at the history of the unsupported builders.
• Removed links to some useless views.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #1333 (Survey existing FTP servers and clients to figure out how LIST works)
• #4685 (IResolver doesn't document its argument types or return values)
• #5797 (constants cannot be attributes of another class)
• #5852 (Deprecating tlsMode)
• #5918 (t.p.b.StatefulStringProtocol has undocumented .state instance attribute)
• #5953 (Split up and improve a couple of printing tests for twisted.python.failure)
• #5989 (Standardize twisted names examples to use task.react)
• #6218 (AbstractMaildirDomain implements IAliasableDomain but doesn't advertise that fact.)
• #6256 (Long-lived KnownHostsFile instance will clobber changes made by others if its `save` method is used)
• #6259 (epoll reactor continually errors when given a delayed call with an excessive timeout)
• #6297 (Remove usage of twisted.python.compat.set and frozenset)
• #6322 (Missing tests for NotImplementedError in t.protocols.basic)
• #6332 (fake twisted.trial._dist.test.test_workertrial.MainTestCase.fdopen returns None sometimes)
• #6338 (IResolver docstrings contain broken references)
• #6349 (MemoryReactor incompletely implements IReactorSocket)
• #6337 (OpenSSLCertificateOptions doesn’t disallow SSLv2)
• #6354 (Main NEWS file is not generated properly anymore)

Other tickets I have reviewed:

• #84 (We need tests for example code)
• #585 (Include sendfile(2) support into defaultreactor)
• #4859 (client endpoint: super-smart name-based TCP connection algorithm)
• #5386 (Get rid of references and code specific to Python 2.3)
• #5411 (ftp_NLST and ftp_LIST should only send data as "str")
• #5513 (Detailed documentation on Proxy by adding docstrings to many of the methods.)
• #5952 (Improve docstring for test_notTrapped in twisted.test.test_failure)
• #5955 (Move inlineCallbacks test from twisted.test.test_failure to somewhere better (test_defer?))
• #6220 (Replace Deprecated Assertion Methods in twisted.conch)
• #6240 (Merge `twisted/internet/<sub>utilspy3</sub>.py` into `twisted/internet/utils.py`)
• #6286 (SSL server endpoints string syntax results in creation of DefaultOpenSSLContextFactory)

Tickets I have closed:

• #6290 (TimerService.stopService should wait for a running call to finish.)
• #6323 (twisted.python.test.test_reflect emits DeprecationWarning)
• #6324 (twisted/python/test/test_util.py emits DeprecationWarning)
• #6326 (web/test_template emits DeprecationWarning)

Other tickets I have worked on:

• #601 (ThrottlingFactory doesn't throttle static web resource)
  • #6339 (Make twisted.protocol.tls._PullToPush public.)
• #3231 (twisted.trial.test.test_testvisitor emits deprecation warnings)
• #5513 (Detailed documentation on Proxy by adding docstrings to many of the methods.)
• #5921 (Trial fails flushing reporter stream with ENOSPC on Windows)
• #6291 (SyncTestCase.assertNoResult should not eat any eventual result.)
• #6314 (There are failing tests with tip of python 2.7 branch)
• #6333 (Deprecate DryRunVisitor.)