Report the Third

During the past three weeks, 23 tickets got some attention that they would not have received without the sponsored development. The result was 9 closed tickets and 8 other tickets unblocked for other developers to resume work on.

I also spent some time working on getting newly donated slaves setup, as well as documenting the setup of the main twistedmatrix.com server, in preparation for automating the redeployment of services to new hardware.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #1333: Survey existing FTP servers and clients to figure out how LIST works
• #3908: Code using twisted.names.client.Resolver is hard to unit test
• #6240: Merge `twisted/internet/_utilspy3.py` into `twisted/internet/utils.py`
• #6337: OpenSSLCertificateOptions doesn’t disallow SSLv2
• #6354: Main NEWS file is not generated properly anymore
• #6377: print traceback in successResultOf error reporting
• #6380: Add optional expected exception types to failureResultOf
• #6392: Typo in test_irc

Other tickets I have reviewed:

• #5126: Add http cache support to Agent
• #5270: Add API to endpoints for connecting a protocol instance
• #5386: Get rid of references and code specific to Python 2.3
• #5411: ftp_NLST and ftp_LIST should only send data as "str"
• #5955: Move inlineCallbacks test from twisted.test.test_failure to somewhere better (test_defer?)
• #6286: SSL server endpoints string syntax results in creation of DefaultOpenSSLContextFactory
• #6341: Replace usage of twisted.python.text and deprecate it
• #6350: Add a few unittest2 assertions to TestCase

Tickets I have closed:

• #6316: Minor cleanup of pam tests in `twisted.test.test_newcred`.

Other tickets I have worked on:

• #1009: Document inlineCallbacks
• #6251: Add a helper function for getting the body of an HTTP request.
• #6284: FTP.ftp_STOR() should handle IsADirectoryError error
• #6286: SSL server endpoints string syntax results in creation of DefaultOpenSSLContextFactory
• #6363: Make twisted.trial.unittest._iterateTests public.

Second Fellowship Report

I've completed my second two weeks of development. I again spent a large amount of my time reviewing tickets. In addition, I did some development work, as well as buildbot improvements.

All told, 42 tickets got some attention that they would not have received without the sponsored development. The result was 23 closed tickets and 14 other tickets unblocked for other developers to resume work on.

Buildbot improvements

• Added a pyflakes builder.
• Improved lint-like builders to only show new warnings/errors introduced in the branch, rather than relative to the tip of trunk
• Added a form to the build results page to allow switching branches and forcing builds.
• Added an easy way to look at the history of the unsupported builders.
• Removed links to some useless views.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #1333 (Survey existing FTP servers and clients to figure out how LIST works)
• #4685 (IResolver doesn't document its argument types or return values)
• #5797 (constants cannot be attributes of another class)
• #5852 (Deprecating tlsMode)
• #5918 (t.p.b.StatefulStringProtocol has undocumented .state instance attribute)
• #5953 (Split up and improve a couple of printing tests for twisted.python.failure)
• #5989 (Standardize twisted names examples to use task.react)
• #6218 (AbstractMaildirDomain implements IAliasableDomain but doesn't advertise that fact.)
• #6256 (Long-lived KnownHostsFile instance will clobber changes made by others if its `save` method is used)
• #6259 (epoll reactor continually errors when given a delayed call with an excessive timeout)
• #6297 (Remove usage of twisted.python.compat.set and frozenset)
• #6322 (Missing tests for NotImplementedError in t.protocols.basic)
• #6332 (fake twisted.trial._dist.test.test_workertrial.MainTestCase.fdopen returns None sometimes)
• #6338 (IResolver docstrings contain broken references)
• #6349 (MemoryReactor incompletely implements IReactorSocket)
• #6337 (OpenSSLCertificateOptions doesn’t disallow SSLv2)
• #6354 (Main NEWS file is not generated properly anymore)

Other tickets I have reviewed:

• #84 (We need tests for example code)
• #585 (Include sendfile(2) support into defaultreactor)
• #4859 (client endpoint: super-smart name-based TCP connection algorithm)
• #5386 (Get rid of references and code specific to Python 2.3)
• #5411 (ftp_NLST and ftp_LIST should only send data as "str")
• #5513 (Detailed documentation on Proxy by adding docstrings to many of the methods.)
• #5952 (Improve docstring for test_notTrapped in twisted.test.test_failure)
• #5955 (Move inlineCallbacks test from twisted.test.test_failure to somewhere better (test_defer?))
• #6220 (Replace Deprecated Assertion Methods in twisted.conch)
• #6240 (Merge `twisted/internet/<sub>utilspy3</sub>.py` into `twisted/internet/utils.py`)
• #6286 (SSL server endpoints string syntax results in creation of DefaultOpenSSLContextFactory)

Tickets I have closed:

• #6290 (TimerService.stopService should wait for a running call to finish.)
• #6323 (twisted.python.test.test_reflect emits DeprecationWarning)
• #6324 (twisted/python/test/test_util.py emits DeprecationWarning)
• #6326 (web/test_template emits DeprecationWarning)

Other tickets I have worked on:

• #601 (ThrottlingFactory doesn't throttle static web resource)
  • #6339 (Make twisted.protocol.tls._PullToPush public.)
• #3231 (twisted.trial.test.test_testvisitor emits deprecation warnings)
• #5513 (Detailed documentation on Proxy by adding docstrings to many of the methods.)
• #5921 (Trial fails flushing reporter stream with ENOSPC on Windows)
• #6291 (SyncTestCase.assertNoResult should not eat any eventual result.)
• #6314 (There are failing tests with tip of python 2.7 branch)
• #6333 (Deprecate DryRunVisitor.)

Welcome our new Twisted Fellow: Tom Prince

Twisted is an open, community-based project that aims for the highest quality and technical standards. As a community-based open source project, Twisted is for the most part run by volunteers, with code contributed by users and developers. As part of our ongoing goal to produce reliable, maintainable software we have strict requirements for coding standards, unit testing and code reviews. Unfortunately, sometimes these goals work at cross purposes. For example, code reviews have become a bottleneck for our development process; they're hard thankless work. There's a reason they'll get you the most points in our high scores.

The Twisted Maintainer Fellowship is our attempt to bridge these two goals: to remove bottlenecks and get necessary work done, thus enabling more contributions from the community. By paying for the Fellow's efforts we can ensure an ongoing focus on the maintenance needs of Twisted, most importantly code reviews.

I am happy to announce that we have signed a contract with Tom Prince to be our new Fellow. Tom Prince is a core developer of Buildbot, who became a Twisted contributor last year via his involvement with the Buildbot project. As a result, he has been maintaining Twisted's buildbot deployment on a volunteer basis for the last eight months.  He also maintains the buildbots of other open source projects.

As you can see from the progress report below, Tom is already hard at work! I encourage you to donate to Twisted via the Software Freedom Conservancy (a 501(c)3 non-profit). By paying for Tom's time you can help support our efforts to maintain and improve Twisted.

---

Tom Prince's First Progress Report

I'm pleased to announce that I have been accepted as a Twisted fellow and full-time maintainer for 2013. I've completed my first two weeks of development. I spent the majority of my time clearing the review queue, from 32 tickets when I started to a low of 4 tickets.

All told, 42 tickets got some attention that they would not have received without the sponsored development. The result was 10 closed tickets and 29 other tickets unblocked for other developers to resume work on.

This work is made possible by the sponsorship of individuals and organizations which have donated to the Twisted project, part of the Software Freedom Conservancy, a not-for-profit organization that helps promote, improve, and develop open source software. Thanks!

The tickets I reviewed, that have now been closed:

• #2915 (Provide way of incrementing patch number with date-based versioning)
• #5601 (Add a howto for "Deploying Twisted with SystemD")
• #5925 (Deprecate twisted.python.runtime.Platform.isWinNT)
• #5937 (Check current Cooperator status)
• #6026 (MultiService.stopService doesn't handle failures in startService)
• #6208 (Admin scripts don't tweak sys.path)
• #6265 (SafeRepr.test_brokenReprIncludesID)
• #6282 (Trial tracebacks are not properly trimmed since 12.3.0)
• #6288 (OpenSSLCertificateOptions contains asserts)
• #6309 (getProcessOutput doc string should use proper epydoc instead of *this*)

Other tickets I have reviewed:

• #585 (Include sendfile(2) support into defaultreactor)
• #2611 (Protocols in twisted.protocols.basic use O(n**2) complexity)
• #4151 (Remove deprecated IDomain.startMessage)
• #4152 (Remove deprecated DomainSMTP and DomainESMTP)
• #4173 (WebSocket server support)
• #4398 (PBServerFactory should support plain password credentials)
• #4623 (Missing interface IQueue)
• #4685 (IResolver doesn't document its argument types or return values)
• #4696 (client endpoint: process)
• #4847 (Improve integration of SerialPort (via an endpoint))
• #5270 (Add API to endpoints for connecting a protocol instance)
• #5386 (Get rid of references and code specific to Python 2.3)
• #5411 (ftp_NLST and ftp_LIST should only send data as "str")
• #5787 (trial –order for selecting an order for running test cases)
• #5797 (constants cannot be attributes of another class)
• #5852 (Deprecating tlsMode)
• #5864 (Remove a sha1 import from < 2.5)
• #5953 (Split up and improve a couple of printing tests for twisted.python.failure)
• #5981 (Clean up twisted.python.threadpool implementation using context managers)
• #5989 (Standardize twisted names examples to use task.react)
• #6042 (twisted.protocols.test.test_basic doesn't following coding standard)
• #6118 (twisted.web.http.Request.noLongerQueued has no test coverage)
• #6120 (twisted.web.http.Request.__repr__ is untested)
• #6165 (Docstring for twisted.trial.unittest.SynchronousTestCase.mktemp not informative enough)
• #6249 (twisted.mail.pop3client.__all__ should be empty, so API docs list those objects in correct module)
• #6256 (Long-lived KnownHostsFile instance will clobber changes made by others if its `save` method is used)
• #6259 (epoll reactor continually errors when given a delayed call with an excessive timeout)
• #6284 (FTP.ftp_STOR() should handle IsADirectoryError error)
• #6302 (FlagConstant objects should be iterable)

Other tickets I have worked on:

• #6290 (TimerService.stopService should wait for a running call to finish.)
• #6314 (There are failing tests with tip of python 2.7 branch)
• #6044 (Deprecate `deferredGenerator')
  • #6315 (twisted/words/test/test_service.py uses `deferredGenerator`)